Add pep517 section #1540
Add pep517 section #1540
Conversation
src/maintainer/knowledge_base.rst
Outdated
| ``ModuleNotFoundError`` during test | ||
| """"""""""""""""""""""""""""""""""" | ||
|
|
||
| When problems occur at the interacton of ``pip`` and more exotic build tools like |
There was a problem hiding this comment.
Is it "interaction" or "intersection"? (note the spelling error)
There was a problem hiding this comment.
i guess it's interaction, as they are both "agents doing stuff" rather than "states of being"... thanks for the heads-up!
src/maintainer/knowledge_base.rst
Outdated
| .. code-block:: yaml | ||
|
|
||
| build: | ||
| script: {{ PYTHON }} -m pip install . -vv --use-deprecated=out-of-tree-build |
There was a problem hiding this comment.
Can we just add this env variable in conda-build?
There was a problem hiding this comment.
it appears we can, as it's been under test as of the 20.x, and likely worked before.
So is the thinking, in order:
conda-buildor...conda-smithyandstaged-recipes
There was a problem hiding this comment.
That's what PR ( conda/conda-build#4294 ) does. We raised this in the last Conda Community meeting.
There was a problem hiding this comment.
Feel free to suggest improvements in the PR
There was a problem hiding this comment.
soooo.... i actually tried a couple-layer-deep set of out-of-tree-build, and found that it left some duplicate paths, namely lib/python3.9/site-packages/LICENSE which seemed kinda unsettling...
There was a problem hiding this comment.
Fixed in conda-forge/poetry-core-feedstock#11
|
This build of the docs failing here is a bad sign. Anyone have any ideas? |
|
My bet's on: |
|
Any ideas on a safe pin @bollwyvl? |
|
Previous So maybe |
|
Yerp, looks like the |
|
Welp, maybe this is a bad idea to document anyway if there's a real fix on the horizon... or we can just link to that as "the future"... close at will... will do a separate PR of just 375fc8c |
|
Opened #1541 |
There was this issue I opened some time back #1174 and this PR would resolve it. |
|
Is this still an issue? I haven't seen it for some time on staged-recipes. |
|
There is still no recommendation of what to do in the knowledge base. I personally am still confused about how to deal with the duplicate role of a pyproject.toml and meta.yaml file. |
|
@conda-forge/core Do you know anything more here? |
|
I think the rule of the thumb is to add the |
That's at least what I've been doing and it seems to be working well! |
|
If that is the recommended practice, then it would be great to get it into the knowledge base. |
|
relevant discussion also here (cross referencing it) #1778 (comment) |
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Rebased and ported to Docusaurus. You can see the rendered section at https://deploy-preview-1540--conda-forge-previews.netlify.app/docs/maintainer/knowledge_base/#pep517. |
Co-authored-by: Nicholas Bollweg <[email protected]>
PR Checklist:
srcdirectory, not indocsor in the html filesThis issue has come up a couple times on gitter, figured it's worth highlighting here, sorry for not making an issue first...
@ocefpaf @beckermr